Include docs for common config #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 64 64
Lines 3076 3076
=======================================
Hits 2769 2769
Misses 207 207
Partials 100 100Continue to review full report at Codecov.
|
jpkrohling
reviewed
Apr 8, 2019
README.adoc
Outdated
| @@ -486,6 +486,24 @@ spec: | |||
|
|
|||
| NOTE: the default create-schema job uses `MODE=prod`, which implies a replication factor of `2`, using `NetworkTopologyStrategy` as the class, effectively meaning that at least 3 nodes are required in the Cassandra cluster. If a `SimpleStrategy` is desired, set the mode to `test`, which then sets the replication factor of `1`. Refer to the link:https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/cassandra/schema/create.sh[create-schema script] for more details. | |||
|
|
|||
| == Finer grained configuration | |||
|
|
|||
| The custom resource can be used to define finer grained kubernetes configuration applied to all Jaeger components or at the individual component level. | |||
There was a problem hiding this comment.
s/kubernetes/Kubernetes/
|
|
||
| * link:https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/[tolerations] in conjunction with `taints` to enable pods to avoid being repelled from a node | ||
|
|
||
| * link:https://kubernetes.io/docs/concepts/storage/volumes/[volumes] and volume mounts |
There was a problem hiding this comment.
Could you include an example? A complete YAML, perhaps based on the simple-prod-deploy-es.yaml (without the spec/storage/elasticsearch node)?
Signed-off-by: Gary Brown <gary@brownuk.com>
jpkrohling
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Brown gary@brownuk.com