Add support for affinity and tolerations #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
========================================
+ Coverage 89.94% 90% +0.05%
========================================
Files 64 64
Lines 3054 3071 +17
========================================
+ Hits 2747 2764 +17
Misses 207 207
Partials 100 100
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Apr 5, 2019
|
|
||
| // Keys are not unique, so should be aggregation of all tolerations | ||
| assert.Len(t, merged.Tolerations, 3) | ||
| assert.Equal(t, "toleration1", merged.Tolerations[0].Key) |
There was a problem hiding this comment.
This looks wrong at a first glance, but reading the docs makes it clear that it's OK to have two entries with the same key/operator/value, as long as the effect is different. Perhaps add a link to the relevant docs, to avoid future confusion?
Signed-off-by: Gary Brown <gary@brownuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining values from the specific component and general details has been done on the following basis:
Affinity - there is no information about merging the information from two affinity definitions - so seems most appropriate approach is to just allow the more specific component's affinity definition to override any general one
Tolerations - an array - the
Keyfield is not unique, so not possible to select on that basis (as with annotations) - so just aggregate all of the tolerations from the specific component and general definitions.Resolves #292
Signed-off-by: Gary Brown gary@brownuk.com