Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ES operator apiversion #360

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Change ES operator apiversion #360

merged 2 commits into from
Apr 4, 2019

Conversation

objectiser
Copy link
Contributor

Fixes #358

Signed-off-by: Gary Brown gary@brownuk.com

Signed-off-by: Gary Brown <gary@brownuk.com>
@objectiser
Copy link
Contributor Author

@jpkrohling I ran dep ensure and seem to have picked up some changes that are related to other PRs (e.g. openshift security). Technically this may not be required in this PR, but thought better to be up-to-date and leave it.

Have ran the e2e tests and they completed without any problems:

Running Smoke end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	201.684s
Creating namespace default
service/cassandra created
statefulset.apps/cassandra created
Running Cassandra end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	191.023s
statefulset.apps/elasticsearch created
service/elasticsearch created
Running Elasticsearch end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	146.661s
namespace/openshift-logging created
customresourcedefinition.apiextensions.k8s.io/prometheusrules.monitoring.coreos.com created
customresourcedefinition.apiextensions.k8s.io/servicemonitors.monitoring.coreos.com created
serviceaccount/elasticsearch-operator created
clusterrole.rbac.authorization.k8s.io/elasticsearch-operator created
clusterrolebinding.rbac.authorization.k8s.io/elasticsearch-operator-rolebinding created
customresourcedefinition.apiextensions.k8s.io/elasticsearches.logging.openshift.io created
deployment.apps/elasticsearch-operator created
Running Self provisioned Elasticsearch end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	0.069s

@jpkrohling
Copy link
Contributor

Have ran the e2e tests and they completed without any problems:

Could you run it twice? If it works, you solved #355 as well.

Signed-off-by: Gary Brown <gary@brownuk.com>
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   89.94%   89.94%           
=======================================
  Files          64       64           
  Lines        3054     3054           
=======================================
  Hits         2747     2747           
  Misses        207      207           
  Partials      100      100
Impacted Files Coverage Δ
pkg/apis/io/v1alpha1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/apis/jaegertracing/v1/jaeger_types.go 100% <ø> (ø) ⬆️
pkg/inventory/elasticsearch.go 86.66% <100%> (ø) ⬆️
pkg/storage/elasticsearch.go 81.53% <100%> (ø) ⬆️
pkg/controller/jaeger/elasticsearch.go 55.76% <100%> (ø) ⬆️
pkg/strategy/strategy.go 91.52% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e6d0f...8964e1b. Read the comment docs.

@objectiser
Copy link
Contributor Author

@jpkrohling When I run it second time, I get failure in the smoke tests. I tried this twice and got the same behaviour:

Running Smoke end-to-end tests...
time="2019-04-04T12:30:29+01:00" level=info msg="passing &{{Jaeger jaegertracing.io/v1} {my-jaeger  smoke-smoke-my-jaeger-1554377419    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] nil [] } {allInOne { {map[memory.max-traces:10000 log-level:debug]} {[] [] map[] {map[] map[]}}} {0 <nil>  {map[]} {[] [] map[] {map[] map[]}}} {0 <nil>  {map[]} {[] [] map[] {map[] map[]}}} {0 <nil>  {map[]} {[] [] map[] {map[] map[]}}} {  {map[]} {[] [] map[] {map[] map[]}}} {{[]}} {{[]}} {  {map[]} {<nil>   } {<nil>     false false false} {<nil> 0  } {   } { {map[] map[]} 0 map[] {<nil> <nil>} }} {<nil>  {[] [] map[] {map[] map[]}}} {[] [] map[] {map[] map[]}}} {}}"
time="2019-04-04T12:32:35+01:00" level=info msg="passing &{{Jaeger jaegertracing.io/v1} {agent-as-daemonset  smoke-smoke-daemonset-1554377549    0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] nil [] } {allInOne { {map[]} {[] [] map[] {map[] map[]}}} {0 <nil>  {map[]} {[] [] map[] {map[] map[]}}} {0 <nil>  {map[]} {[] [] map[] {map[] map[]}}} {0 <nil>  {map[]} {[] [] map[] {map[] map[]}}} {DaemonSet  {map[log-level:debug]} {[] [] map[] {map[] map[]}}} {{[]}} {{[]}} {  {map[]} {<nil>   } {<nil>     false false false} {<nil> 0  } {   } { {map[] map[]} 0 map[] {<nil> <nil>} }} {<nil>  {[] [] map[] {map[] map[]}}} {[] [] map[] {map[] map[]}}} {}}"
--- FAIL: TestSmoke (266.07s)
    --- FAIL: TestSmoke/smoke (266.04s)
        --- FAIL: TestSmoke/smoke/my-jaeger (130.10s)
            client.go:57: resource type RoleBinding with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) created
            client.go:57: resource type Role with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) created
            client.go:57: resource type ServiceAccount with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) created
            client.go:57: resource type Deployment with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) created
            utils.go:56: Initialized cluster resources. Namespace: smoke-smoke-my-jaeger-1554377419
            wait_util.go:61: Waiting for full availability of jaeger-operator deployment (0/1)
            wait_util.go:67: Deployment available (1/1)
            client.go:57: resource type Jaeger with namespace/name (smoke-smoke-my-jaeger-1554377419/my-jaeger) created
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            wait_util.go:52: Waiting for availability of my-jaeger deployment
            all_in_one_test.go:34: timed out waiting for the condition
            client.go:75: resource type Jaeger with namespace/name (smoke-smoke-my-jaeger-1554377419/my-jaeger) successfully deleted
            client.go:75: resource type Deployment with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) successfully deleted
            client.go:75: resource type ServiceAccount with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) successfully deleted
            client.go:75: resource type Role with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) successfully deleted
            client.go:75: resource type RoleBinding with namespace/name (smoke-smoke-my-jaeger-1554377419/jaeger-operator) successfully deleted
        --- FAIL: TestSmoke/smoke/daemonset (125.45s)
            client.go:57: resource type RoleBinding with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) created
            client.go:57: resource type Role with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) created
            client.go:57: resource type ServiceAccount with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) created
            client.go:57: resource type Deployment with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) created
            utils.go:56: Initialized cluster resources. Namespace: smoke-smoke-daemonset-1554377549
            wait_util.go:67: Deployment available (1/1)
            client.go:57: resource type Jaeger with namespace/name (smoke-smoke-daemonset-1554377549/agent-as-daemonset) created
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            wait_util.go:47: Waiting for availability of agent-as-daemonset-agent-daemonset daemonset
            daemonset.go:33: timed out waiting for the condition
            client.go:75: resource type Jaeger with namespace/name (smoke-smoke-daemonset-1554377549/agent-as-daemonset) successfully deleted
            client.go:75: resource type Deployment with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) successfully deleted
            client.go:75: resource type ServiceAccount with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) successfully deleted
            client.go:75: resource type Role with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) successfully deleted
            client.go:75: resource type RoleBinding with namespace/name (smoke-smoke-daemonset-1554377549/jaeger-operator) successfully deleted
        --- FAIL: TestSmoke/smoke/sidecar (10.49s)
            client.go:57: resource type RoleBinding with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) created
            client.go:57: resource type Role with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) created
            client.go:57: resource type ServiceAccount with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) created
            client.go:57: resource type Deployment with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) created
            utils.go:56: Initialized cluster resources. Namespace: smoke-smoke-sidecar-1554377675
            wait_util.go:67: Deployment available (1/1)
            client.go:57: resource type Jaeger with namespace/name (smoke-smoke-sidecar-1554377675/agent-as-sidecar) created
            client.go:57: resource type Deployment with namespace/name (smoke-smoke-sidecar-1554377675/vertx-create-span-sidecar) created
            wait_util.go:67: Deployment available (1/1)
            sidecar.go:30: could not find pod with image jaegertracing/all-in-one
            client.go:75: resource type Deployment with namespace/name (smoke-smoke-sidecar-1554377675/vertx-create-span-sidecar) successfully deleted
            client.go:75: resource type Jaeger with namespace/name (smoke-smoke-sidecar-1554377675/agent-as-sidecar) successfully deleted
            client.go:75: resource type Deployment with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) successfully deleted
            client.go:75: resource type ServiceAccount with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) successfully deleted
            client.go:75: resource type Role with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) successfully deleted
            client.go:75: resource type RoleBinding with namespace/name (smoke-smoke-sidecar-1554377675/jaeger-operator) successfully deleted
FAIL
FAIL	github.com/jaegertracing/jaeger-operator/test/e2e	266.139s
make: *** [Makefile:86: e2e-tests-smoke] Error 1

@objectiser
Copy link
Contributor Author

@jkandasa If you get a chance, would be good if you could give the fix a quick try using objectiser/jaeger-operator:latest ?

@objectiser objectiser merged commit 7f314b5 into jaegertracing:master Apr 4, 2019
@objectiser objectiser deleted the fixesver branch April 4, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants