Derive agent container/host ports from options if specified #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 89.88% 89.94% +0.05%
==========================================
Files 64 64
Lines 3035 3052 +17
==========================================
+ Hits 2728 2745 +17
Misses 207 207
Partials 100 100
Continue to review full report at Codecov.
|
|
@jpkrohling Tested with both daemonset and sidecar agents (within Istio aswell). |
jpkrohling
approved these changes
Apr 3, 2019
| ContainerPort: 5775, | ||
| HostPort: 5775, | ||
| ContainerPort: zkCompactTrft, | ||
| HostPort: zkCompactTrft, |
There was a problem hiding this comment.
Nothing against this name, but for the record, I used "zk-compact-trft" as the name because of size limitations in the name field for the port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using hardcoded ports, so traffic wasn't getting through to the agent when the ports were changed using the options.
Signed-off-by: Gary Brown gary@brownuk.com