Update test to run on OpenShift

[kevinearls]

Signed-off-by: Kevin Earls kearls@redhat.com

This resolves #327 by taking actions that are needed to permit this test to run on OpenShift. Part of the solution is a bit hacky as it uses os.Exec to call the "oc adm" command, which means the oc client needs to be on the path wherever this test is being run.

It would be preferable to use either the OpenShift Go client of the Rest API to do this, but we don't use those anywhere else in the tests and adding them would be non-trivial. I will open an issue to do this in the future.

[jpkrohling]

This change is 

[codecov]

Codecov Report

Merging #350 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          64       64           
  Lines        3035     3035           
=======================================
  Hits         2728     2728           
  Misses        207      207           
  Partials      100      100

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6e569...6117d64. Read the comment docs.

[kevinearls]

@jpkrohling @objectiser Please review.

[objectiser]

LGTM - but @jpkrohling should also check.

[jpkrohling]

, just a couple of minor, non-blocking things.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kevinearls)

---

test/e2e/daemonset.go, line 50 at r1 (raw file):

		}

		cmd := exec.Command("oc", "adm", "--namespace", namespace, "policy",  "add-scc-to-user", "daemonset-with-hostport", "-z", "default")

Could you add a code comment, explaining your choice? Like, "ideally, we would use the REST API, but for a single-usage within the project, this is the simplest solution that works".

---

test/e2e/daemonset.go, line 214 at r1 (raw file):

}

func hostportSccDaemonset() (*osv1sec.SecurityContextConstraints) {

s/hostport/hostPort/?

[jpkrohling]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[kevinearls]

@objectiser @jpkrohling Can one of you guys merge this? Juca I assume the code-review/reviewable failure is because you turned that off?

[jpkrohling]

That's correct. Sorry I didn't merge it earlier, I was holding it off until I executed the tests locally and ran into #355, but I assume you tested it as well.