Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntelliJ specific files to gitignore #33

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 20, 2018

No description provided.

@jpkrohling
Copy link
Contributor

This change is Reviewable

Signed-off-by: Georgios Andrianakis <geoand@gmail.com>
@codecov
Copy link

codecov bot commented Sep 20, 2018

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          16       16           
  Lines         599      599           
=======================================
  Hits          594      594           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78bb8...975568d. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)


.gitignore, line 110 at r1 (raw file):


### IntelliJ ###
.idea

Could you instead generate a new file using gitignore.io? At the top of this file, there's the URL that was used to generate this file here. Add "intellij" to the URL (or "intellij+all") and place the output in this file.

Signed-off-by: Georgios Andrianakis <geoand@gmail.com>
@geoand
Copy link
Contributor Author

geoand commented Sep 20, 2018

@jpkrohling Didn't know about gitignore.io, nice :)

I pushed a second commit to the PR

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jpkrohling jpkrohling merged commit fb91503 into jaegertracing:master Sep 20, 2018
@jpkrohling
Copy link
Contributor

Thanks!

@geoand
Copy link
Contributor Author

geoand commented Sep 20, 2018 via email

@geoand geoand deleted the intellij-ignore branch September 20, 2018 13:46
dt-cloner bot pushed a commit to IshwarKanse/jaeger-operator that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants