Added grps port into jaeger collector service #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #306 +/- ##
==========================================
+ Coverage 88.63% 88.64% +0.01%
==========================================
Files 70 70
Lines 3140 3143 +3
==========================================
+ Hits 2783 2786 +3
Misses 244 244
Partials 113 113
Continue to review full report at Codecov.
|
|
@pavolloffay I think the grpc port should be exposed, but vaguely remember a discussion about whether the health port should just remain internal, so only accessible by k8s/prometheus? |
|
I think healtchecks should be internal |
|
@jkandasa could you update the PR to remove the health check port? |
…r service Signed-off-by: Jeeva kandasamy <jkandasa@redhat.com>
jkandasa
force-pushed
the
collector-service-update
branch
from
70f6bab
to
389902b
Compare
jkandasa
changed the title
|
@objectiser updated. |
objectiser
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #305,
Added grpc port into collector service.