Change operator.yaml to use master, to keep the readme uptodate with … #296
Conversation
…latest version Signed-off-by: Gary Brown <gary@brownuk.com>
|
This change is |
|
To avoid problem reported in #293 . |
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
Coverage ? 88.52%
=========================================
Files ? 70
Lines ? 3110
Branches ? 0
=========================================
Hits ? 2753
Misses ? 244
Partials ? 113Continue to review full report at Codecov.
|
| @@ -16,7 +16,7 @@ spec: | |||
| serviceAccountName: jaeger-operator | |||
| containers: | |||
| - name: jaeger-operator | |||
| image: jaegertracing/jaeger-operator:1.10.0 | |||
| image: jaegertracing/jaeger-operator:master | |||
There was a problem hiding this comment.
Is this a temporary fix?
If so add a note to release V1 issue that it has to be changed when releasing.
There was a problem hiding this comment.
Not sure if should be temporary - if we fix on a particular version, then the readme needs to reflect that version until the next stable version is released, rather than the current approach where we update the readme as changes are applied.
Something we should discuss when @jpkrohling is available.
There was a problem hiding this comment.
I would expect (and I think most users too) that when you download https://github.com/jaegertracing/jaeger-operator/blob/v1.10.0/deploy/operator.yaml - (mind the tag version in the link) that it would deploy operator with the given version.
There was a problem hiding this comment.
This change gets overridden every time we do a release:
jaeger-operator/.travis/release.sh
Line 16 in 3b6e569
This file is also used as the base for other operator-related files, like the test manifests and OLM CSV (IIRC).
To address the original problem this PR is fixing, I think we could mention in the documentation the version a change will take effect ("from version 1.11.0, the apiVersion should be ...")
…latest version
Signed-off-by: Gary Brown gary@brownuk.com