Add Elasticsearch image to CR and flag #289
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
This change is |
| @@ -66,6 +66,9 @@ func NewStartCommand() *cobra.Command { | |||
| cmd.Flags().String("jaeger-es-rollover-image", "jaegertracing/jaeger-es-rollover", "The Docker image for the Jaeger Elasticsearch Rollover") | |||
| viper.BindPFlag("jaeger-es-rollover-image", cmd.Flags().Lookup("jaeger-es-rollover-image")) | |||
|
|
|||
| cmd.Flags().String("jaeger-elasticsearch-image", "quay.io/openshift/origin-logging-elasticsearch5:latest", "The Docker image for Elasticsearch") | |||
There was a problem hiding this comment.
pavolloffay
requested review from
jpkrohling and
objectiser
and removed request for
jpkrohling
|
Not sure why it generates two additional files - @jpkrohling shall we ignore them? |
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 88.45% 88.52% +0.06%
==========================================
Files 71 70 -1
Lines 3109 3110 +1
==========================================
+ Hits 2750 2753 +3
+ Misses 246 244 -2
Partials 113 113
Continue to review full report at Codecov.
|
|
@pavolloffay those are new as of 0.5.0. You can leave them in this PR, just include them in the |
There was a problem hiding this comment.
.codecov.yml, or remove them from the PR. Other than that, it's ready to be merged.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @objectiser and @pavolloffay)
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Resolves #215
Signed-off-by: Pavol Loffay ploffay@redhat.com