Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added publishing of major.minor image for the operator #274

Merged

Conversation

jpkrohling
Copy link
Contributor

@jpkrohling jpkrohling commented Mar 6, 2019

Closes #187
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #274   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files          68       68           
  Lines        2895     2895           
=======================================
  Hits         2575     2575           
  Misses        211      211           
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f69b83...7841234. Read the comment docs.

@objectiser
Copy link
Contributor

Is it worth doing major version aswell?

@jpkrohling
Copy link
Contributor Author

We could, although I don't remember seeing it used in practice.

@jpkrohling
Copy link
Contributor Author

I'll merge this without tagging only the major part. If we get a request for that, we could implement based on the logic from this PR.

@jpkrohling jpkrohling merged commit 6cc3c89 into jaegertracing:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants