Store back the CR only if it has changed #249
Conversation
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
- Coverage 89.4% 89.31% -0.1%
=========================================
Files 62 62
Lines 2738 2742 +4
=========================================
+ Hits 2448 2449 +1
- Misses 187 189 +2
- Partials 103 104 +1
Continue to review full report at Codecov.
|
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
231-Check-CR-has-changed
branch
from
75ff1cd
to
396e9fe
Compare
| @@ -109,16 +111,13 @@ func (r *ReconcileJaeger) Reconcile(request reconcile.Request) (reconcile.Result | |||
| return reconcile.Result{}, err | |||
| } | |||
|
|
|||
| logFields.Info("Configured Jaeger instance") | |||
There was a problem hiding this comment.
Do you want to remove it? We could indicate the changes on line 119
There was a problem hiding this comment.
Yeah, I wanted to remove it. As someone managing the cluster, I'm not sure this would be useful at all in the day-to-day. It's certainly useful to get a positive confirmation in the beginning, but considering that there will be one change every 5 seconds (due to the metrics on #248), this would cause too much noise in the logs.
Fixes #231 by comparing the original CR with the post-reconcile state, issuing an update only in case the CR has changed.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de