Make sure that we always use the correct operator-sdk version #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
frzifus
reviewed
Feb 22, 2022
Makefile
Outdated
| @@ -486,7 +487,7 @@ install-tools: | |||
| prepare-release: | |||
| $(VECHO)./.ci/prepare-release.sh | |||
|
|
|||
| scorecard-tests: | |||
| scorecard-tests: operator-sdk | |||
| operator-sdk scorecard bundle -w 600s || (echo "scorecard test failed" && exit 1) | |||
Makefile
Outdated
| @@ -349,7 +350,7 @@ rm -rf $$TMP_DIR ;\ | |||
| endef | |||
|
|
|||
| .PHONY: bundle | |||
| bundle: manifests kustomize ## Generate bundle manifests and metadata, then validate generated files. | |||
| bundle: manifests kustomize operator-sdk ## Generate bundle manifests and metadata, then validate generated files. | |||
| operator-sdk generate kustomize manifests -q | |||
There was a problem hiding this comment.
I think we need to use $(OPERATOR_SDK) here too.
https://github.com/jaegertracing/jaeger-operator/runs/5291691840?check_suite_focus=true#step:6:142
Signed-off-by: Kevin Earls <kearls@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #1777 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 99 99
Lines 5937 5937
=======================================
Hits 5196 5196
Misses 567 567
Partials 174 174 Continue to review full report at Codecov.
|
pavolloffay
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com
Which problem is this PR solving?
Short description of the changes