Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that we always use the correct operator-sdk version #1766

Closed
wants to merge 3 commits into from
Closed

Make sure that we always use the correct operator-sdk version #1766

wants to merge 3 commits into from

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls kearls@redhat.com

Which problem is this PR solving?

  • Make sure we always use the correct version of the operator-sdk in builds. Suggested in chat by @pavolloffay.
  • I can open an issue if needed.

Short description of the changes

  • Added a Makefile target to install the operator-sdk, mostly copied from Pavol's equivalent change to the open-telemetry collector:

Signed-off-by: Kevin Earls <kearls@redhat.com>
frzifus
frzifus previously approved these changes Feb 21, 2022
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operator-sdk installing step should be removed from the GHA workflows

Makefile Outdated
@@ -39,6 +39,7 @@ GOROOT ?= "$(shell go env GOROOT)"
ECHO ?= @echo $(echo_prefix)
SED ?= "sed"
CERTMANAGER_VERSION ?= 1.6.1
OPERATOR_SDK_VERSION ?= 1.17.0
Copy link
Member

@pavolloffay pavolloffay Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project is using 1.13.1

Signed-off-by: Kevin Earls <kearls@redhat.com>
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1766 (a0d19bb) into main (81fdc96) will not change coverage.
The diff coverage is n/a.

❗ Current head a0d19bb differs from pull request most recent head 5abd300. Consider uploading reports for the commit 5abd300 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1766   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files          99       99           
  Lines        5937     5937           
=======================================
  Hits         5196     5196           
  Misses        567      567           
  Partials      174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81fdc96...5abd300. Read the comment docs.

@kevinearls
Copy link
Contributor Author

Mucked this up locally, closing to resubmit...

@kevinearls kevinearls closed this Feb 22, 2022
@kevinearls kevinearls deleted the operator-sdk-install branch February 22, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants