Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log when spak depenencies are used with unsupported storage #161

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

pavolloffay
Copy link
Member

Resolves #157

Signed-off-by: Pavol Loffay ploffay@redhat.com

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@jpkrohling
Copy link
Contributor

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          30       30           
  Lines        1430     1430           
=======================================
  Hits         1378     1378           
  Misses         40       40           
  Partials       12       12
Impacted Files Coverage Δ
pkg/strategy/production.go 100% <100%> (ø) ⬆️
pkg/strategy/all-in-one.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9adb6a2...f49471f. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pavolloffay and @objectiser)


pkg/strategy/all-in-one.go, line 86 at r1 (raw file):

			os = append(os, cronjob.CreateSparkDependencies(c.jaeger))
		} else {
			logrus.WithField("type", c.jaeger.Spec.Storage.Type).Warn("Spark dependencies is enabled for unsupported storage")

Suggestion: "Skipping spark dependencies job due to unsupported storage."

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay
Copy link
Member Author

Changed, I will merge this as there will be conflicts in #162 and I won't be available. I will fix any outstanding issues in follow pr.

@pavolloffay pavolloffay merged commit a3b8455 into jaegertracing:master Dec 7, 2018
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @objectiser)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants