-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E testing for ES Rollover feature #1544
Add E2E testing for ES Rollover feature #1544
Conversation
Signed-off-by: Israel Blancas <iblancas@redhat.com>
017d67b
to
66bc16a
Compare
Signed-off-by: Israel Blancas <iblancas@redhat.com>
This looks good but some lint/code style issues needs to be fixed before, so the CI can pass. |
Signed-off-by: Israel Blancas <iblancas@redhat.com>
…o rollover-testing
@rubenvp8510 thanks for your time reviewing this PR! |
Signed-off-by: Israel Blancas <iblancas@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 94 94
Lines 5956 5956
=======================================
Hits 5217 5217
Misses 562 562
Partials 177 177 Continue to review full report at Codecov.
|
@rubenvp8510 I'm not able to reproduce the issue. It seems to be a one-timer issue... Could we re-run the GitHub workflow? |
Signed-off-by: Israel Blancas <iblancas@redhat.com>
I was able to reproduce the issue and pushed a change that can solve the issue and make the tests more deterministic |
Minor comments, are optional but LGTM.! |
Signed-off-by: Israel Blancas <iblancas@redhat.com>
…or into rollover-testing
Signed-off-by: Israel Blancas <iblancas@redhat.com>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
…or into rollover-testing
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@rubenvp8510 can you take a look to this PR? All the tests are finally passing :) |
Which problem is this PR solving?
Add E2E testing to the Rollover ES feature implemented in #267
Short description of the changes
index
job assert to work with ES indicesreporter
assert job to being able to report more spans in different waystests/cmd-utils/wait-cronjob/
. I tried to detect this using the events from the Kubernetes API and Kuttl but there is a problem and the matching between objects is not correctkuttl-test.yaml
to avoid errors trying to recreate thejaeger-operator-system
Kubernetes namespace