Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E testing for ES Rollover feature #1544

Merged
merged 17 commits into from
Oct 13, 2021

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Add E2E testing to the Rollover ES feature implemented in #267

Short description of the changes

  • Add E2E Test for the Rollover ES feature
  • Add index job assert to work with ES indices
  • Add more capabilities to the reporter assert job to being able to report more spans in different ways
  • Add a cmd to wait until a job scheduled by a cronjob is executed successfully tests/cmd-utils/wait-cronjob/. I tried to detect this using the events from the Kubernetes API and Kuttl but there is a problem and the matching between objects is not correct
  • Small changes in kuttl-test.yaml to avoid errors trying to recreate the jaeger-operator-system Kubernetes namespace

Signed-off-by: Israel Blancas <iblancas@redhat.com>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@rubenvp8510
Copy link
Collaborator

This looks good but some lint/code style issues needs to be fixed before, so the CI can pass.

@iblancasa
Copy link
Collaborator Author

@rubenvp8510 thanks for your time reviewing this PR!

iblancasa and others added 2 commits September 15, 2021 19:45
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #1544 (cd2ea17) into master (93eb3c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1544   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          94       94           
  Lines        5956     5956           
=======================================
  Hits         5217     5217           
  Misses        562      562           
  Partials      177      177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93eb3c4...cd2ea17. Read the comment docs.

@iblancasa
Copy link
Collaborator Author

@rubenvp8510 I'm not able to reproduce the issue. It seems to be a one-timer issue... Could we re-run the GitHub workflow?

Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Copy link
Collaborator Author

I was able to reproduce the issue and pushed a change that can solve the issue and make the tests more deterministic

@rubenvp8510
Copy link
Collaborator

rubenvp8510 commented Sep 30, 2021

Minor comments, are optional but LGTM.!

Signed-off-by: Israel Blancas <iblancas@redhat.com>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Copy link
Collaborator Author

@rubenvp8510 can you take a look to this PR? All the tests are finally passing :)

@rubenvp8510 rubenvp8510 merged commit 2505d69 into jaegertracing:master Oct 13, 2021
@iblancasa iblancasa deleted the rollover-testing branch February 28, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants