Skipping Kafka related tests in examples2 when Kafka is not available #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 90 90
Lines 5146 5146
=======================================
Hits 4437 4437
Misses 539 539
Partials 170 170 Continue to review full report at Codecov.
|
kevinearls
suggested changes
Jan 13, 2021
There was a problem hiding this comment.
@madeelrh This looks better, although the title is misleading. Can you change it to something like "Permit skipping Kafka deployment"
madeelrh
force-pushed
the
skip-kafka-in-examples2
branch
from
8cf0785
to
00f298e
Compare
Signed-off-by: Muhammad Adeel <madeel@redhat.com>
madeelrh
force-pushed
the
skip-kafka-in-examples2
branch
from
00f298e
to
f4b8fc5
Compare
|
@kevinearls commit msg is updated. thanks. |
kevinearls
approved these changes
Jan 14, 2021
objectiser
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.