Add volumes and volume-mounts for spark dependencies #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1359 +/- ##
=======================================
Coverage 86.21% 86.22%
=======================================
Files 90 90
Lines 5144 5146 +2
=======================================
+ Hits 4435 4437 +2
Misses 539 539
Partials 170 170
Continue to review full report at Codecov.
|
|
@rubenvp8510 @objectiser @jpkrohling Please review |
|
LGTM |
objectiser
reviewed
Jan 11, 2021
pkg/cronjob/spark_dependencies.go
Outdated
| }, | ||
| }, | ||
| RestartPolicy: corev1.RestartPolicyNever, | ||
| Affinity: commonSpec.Affinity, | ||
| Tolerations: commonSpec.Tolerations, | ||
| SecurityContext: commonSpec.SecurityContext, | ||
| ServiceAccountName: account.JaegerServiceAccountFor(jaeger, account.DependenciesComponent), | ||
| Volumes: jaeger.Spec.Storage.Dependencies.JaegerCommonSpec.Volumes, |
There was a problem hiding this comment.
nit: Seems like formatting issue - may be worth running make format to see?
Signed-off-by: Kevin Earls <kearls@redhat.com>
objectiser
approved these changes
Jan 12, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com
This fixes #1332 Note however that TLS access for the spark dependencies job is not fully supported (see issue #294 ) in general but will work for the instance described in this issue.