Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e tests es index cleaner namespace issue #1340

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

jkandasa
Copy link
Member

Signed-off-by: Jeeva Kandasamy jkandasa@gmail.com

fixes broken es namespace on es index cleaner test on self-provision mode.

@kevinearls can you please review this? Thanks!

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1340 (cf08010) into master (7d8cab9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1340   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files          90       90           
  Lines        5125     5125           
=======================================
  Hits         4409     4409           
  Misses        548      548           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8cab9...cf08010. Read the comment docs.

Copy link
Contributor

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit bf1bc27 into jaegertracing:master Dec 11, 2020
@jkandasa jkandasa deleted the es-index-test-namespace-fix branch December 11, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants