Copy common spec to avoid touching persisted CR spec

[rubenvp8510]

Signed-off-by: Ruben Vargas Palma ruben.vp8510@gmail.com

[codecov]

Codecov Report

Merging #1333 (8b76555) into master (3160523) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
+ Coverage   87.41%   87.43%   +0.01%     
==========================================
  Files          89       89              
  Lines        5021     5020       -1     
==========================================
  Hits         4389     4389              
+ Misses        467      466       -1     
  Partials      165      165              

Impacted Files	Coverage Δ
pkg/inject/sidecar.go	94.76% <100.00%> (ø)
pkg/apis/jaegertracing/v1/logger.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3160523...8b76555. Read the comment docs.

[objectiser]

@rubenvp8510 could you add a test to confirm that the supplied Jaeger CR is not modified - and that the returned container has the volume/mounts?

[objectiser]

@rubenvp8510 Could you add

	assert.Len(t, jaeger.Spec.Agent.VolumeMounts, 0)
	assert.Len(t, jaeger.Spec.Agent.Volumes, 0)

to https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/inject/sidecar_test.go#L52 and again at the end of the test - i.e. to check there are no volumes/mounts in the initial Jaeger CR and after the sidecar has been injected.

Then I think it is ready to merge.