Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running tests without an external ES instance #1316

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Enable running tests without an external ES instance #1316

merged 4 commits into from
Dec 2, 2020

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls kearls@redhat.com

Signed-off-by: Kevin Earls <kearls@redhat.com>
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1316 (2a77b43) into master (f250749) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
+ Coverage   87.35%   87.41%   +0.05%     
==========================================
  Files          89       89              
  Lines        4999     5021      +22     
==========================================
+ Hits         4367     4389      +22     
  Misses        467      467              
  Partials      165      165              
Impacted Files Coverage Δ
pkg/inject/sidecar.go 94.76% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f250749...2a77b43. Read the comment docs.

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls <kearls@redhat.com>
@kevinearls kevinearls marked this pull request as ready for review November 30, 2020 09:18
test/e2e/elasticsearch_token_propagation_test.go Outdated Show resolved Hide resolved
test/e2e/elasticsearch_test.go Outdated Show resolved Hide resolved
test/e2e/examples2_test.go Show resolved Hide resolved
test/e2e/utils.go Outdated Show resolved Hide resolved
Signed-off-by: Kevin Earls <kearls@redhat.com>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 172683f into jaegertracing:master Dec 2, 2020
@kevinearls kevinearls deleted the skip-es-external branch December 2, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants