Fix secret creation when using self provisioned elasticsearch instances #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 87.32% 87.31% -0.01%
==========================================
Files 89 89
Lines 4947 4952 +5
==========================================
+ Hits 4320 4324 +4
- Misses 464 465 +1
Partials 163 163
Continue to review full report at Codecov.
|
Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls <kearls@redhat.com>
jpkrohling
reviewed
Nov 5, 2020
| @@ -4,6 +4,9 @@ import ( | |||
| "context" | |||
| "testing" | |||
|
|
|||
| corev1 "k8s.io/api/core/v1" | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
There was a problem hiding this comment.
Import order is strange.
There was a problem hiding this comment.
@jpkrohling isn't make fmt supposed to fix this?
test/e2e/multiple_instances_test.go
Outdated
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| type MulitpleInstanceTestSuite struct { |
There was a problem hiding this comment.
Suggested change
| type MulitpleInstanceTestSuite struct { | |
| type MultipleInstanceTestSuite struct { |
test/e2e/multiple_instances_test.go
Outdated
| secondContext, err := createNewTestContext() | ||
| defer secondContext.Cleanup() | ||
| secondNamespace := secondContext.GetID() | ||
| secondjaegerInstance := getJaegerSelfProvSimpleProd(jaegerInstanceName, secondNamespace, 1) |
There was a problem hiding this comment.
Suggested change
| secondjaegerInstance := getJaegerSelfProvSimpleProd(jaegerInstanceName, secondNamespace, 1) | |
| secondJaegerInstance := getJaegerSelfProvSimpleProd(jaegerInstanceName, secondNamespace, 1) |
test/e2e/multiple_instances_test.go
Outdated
| if secondContext != nil { | ||
| secondContext.Cleanup() | ||
| } | ||
| require.FailNow(t, "Failed in prepare with: "+err.Error()) |
There was a problem hiding this comment.
Suggested change
| require.FailNow(t, "Failed in prepare with: "+err.Error()) | |
| require.FailNow(t, "Failed in prepare with: %v", err) |
test/e2e/utils.go
Outdated
| return exampleJaeger | ||
| } | ||
|
|
||
| func createEsSelfProvDeployment(jaegerInstance *v1.Jaeger, jaegerInstanceName, jaegerNamespace string) { |
There was a problem hiding this comment.
Suggested change
| func createEsSelfProvDeployment(jaegerInstance *v1.Jaeger, jaegerInstanceName, jaegerNamespace string) { | |
| func createESSelfProvDeployment(jaegerInstance *v1.Jaeger, jaegerInstanceName, jaegerNamespace string) { |
Signed-off-by: Kevin Earls <kearls@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com