Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dependencies #1264

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

faceair
Copy link
Contributor

@faceair faceair commented Oct 16, 2020

Previous discussions #1257

Signed-off-by: faceair <git@faceair.me>
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1264 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   87.36%   87.38%   +0.01%     
==========================================
  Files          90       90              
  Lines        4907     4913       +6     
==========================================
+ Hits         4287     4293       +6     
  Misses        457      457              
  Partials      163      163              
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100.00% <0.00%> (ø)
pkg/deployment/agent.go 96.21% <0.00%> (+0.11%) ⬆️
pkg/autodetect/main.go 81.63% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5271b85...c9077ea. Read the comment docs.

.ci/vgot.sh Outdated Show resolved Hide resolved
Signed-off-by: faceair <git@faceair.me>
@mergify mergify bot merged commit d7f244f into jaegertracing:master Oct 19, 2020
@faceair faceair deleted the fix-the-dependencies branch October 19, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants