Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip detectClusterRoles for Kubernetes #1262

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Skip detectClusterRoles for Kubernetes #1262

merged 1 commit into from
Oct 19, 2020

Conversation

johanavril
Copy link
Contributor

@johanavril johanavril commented Oct 15, 2020 •
edited by jpkrohling
Loading

Fixes #1261

@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #1262 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   87.36%   87.37%           
=======================================
  Files          90       90           
  Lines        4907     4909    +2     
=======================================
+ Hits         4287     4289    +2     
  Misses        457      457           
  Partials      163      163
Impacted Files Coverage Δ
pkg/autodetect/main.go 81.63% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a51e3...30363b2. Read the comment docs.

@jpkrohling jpkrohling changed the title Skip detectClusterRoles for Kubernetes (#1261) Skip detectClusterRoles for Kubernetes Oct 15, 2020
jpkrohling
jpkrohling reviewed Oct 15, 2020
View reviewed changes
pkg/autodetect/main.go Outdated Show resolved Hide resolved
@johanavril
Skip detectClusterRoles for Kubernetes
30363b2 
Signed-off-by: johanavril <johan.avrilyansen@gmail.com>
@mergify mergify bot merged commit b42b5a0 into jaegertracing:master Oct 19, 2020
@jpkrohling
Copy link
Contributor

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip detectClusterRoles for Kubernetes
2 participants
@johanavril @jpkrohling