Don't set kafka batch options when using otel collector #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1227 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 90 90
Lines 4900 4900
=======================================
Hits 4280 4280
Misses 457 457
Partials 163 163 Continue to review full report at Codecov.
|
objectiser
approved these changes
Sep 30, 2020
prageethw
pushed a commit
to prageethw/jaeger-operator
that referenced
this pull request
Oct 1, 2020
…g#1227) Signed-off-by: Kevin Earls <kearls@redhat.com> Signed-off-by: Prageeth Warnak <prageeth.warnak@team.telstra.com>
prageethw
pushed a commit
to prageethw/jaeger-operator
that referenced
this pull request
Oct 1, 2020
…g#1227) Signed-off-by: Kevin Earls <kearls@redhat.com> Signed-off-by: Prageeth Warnak <prageeth.warnak@team.telstra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com