Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the securityContext to the cassandraCreateSchema job #1167

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Aug 24, 2020

Resolves #1166

Signed-off-by: chgl <chgl@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1167 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1167   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          89       89           
  Lines        5501     5502    +1     
=======================================
+ Hits         4857     4858    +1     
  Misses        474      474           
  Partials      170      170           
Impacted Files Coverage Δ
pkg/storage/cassandra_dependencies.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea13b2...29e4686. Read the comment docs.

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, would you be able to add a test as well, to ensure we don't have a regression in the future?

Signed-off-by: chgl <chgl@users.noreply.github.com>
@chgl
Copy link
Contributor Author

chgl commented Aug 25, 2020

@jpkrohling does this look ok?

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge on green.

@jpkrohling jpkrohling merged commit b2fcc57 into jaegertracing:master Aug 25, 2020
@jpkrohling
Copy link
Contributor

Thank you for your contribution!

@chgl
Copy link
Contributor Author

chgl commented Aug 25, 2020

Thank you and the team for making the contribution experience so smooth :). Hope this doesn't sound impatient: is there an ETA for the next release?

@jpkrohling
Copy link
Contributor

You are actually lucky: we are planning a release this week.

@chgl
Copy link
Contributor Author

chgl commented Aug 25, 2020

Great to hear, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring the securityContext of the CassandraCreateSchema job
2 participants