Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom labels in Jaeger all-in-one deployments (#629) #1153

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

albertteoh
Copy link
Contributor

Proposed fix for Issue #629. Wrote test to fail where "name", "hello" and "another" custom labels have empty corresponding strings in the selectors, then update selector to use commonSpec.Labels, matching the template's labels. Tests pass after change.

Diff also contains a few gofmt and go.sum updates.

Signed-off-by: Albert Teoh <albert.teoh@gmail.com>
Signed-off-by: Albert Teoh <albert.teoh@gmail.com>
Signed-off-by: Albert Teoh <albert.teoh@gmail.com>
@albertteoh albertteoh changed the title Issue 629 Support custom labels in Jaeger all-in-one deployments Aug 11, 2020
@albertteoh albertteoh changed the title Support custom labels in Jaeger all-in-one deployments Support custom labels in Jaeger all-in-one deployments (#629) Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1153 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   88.26%   88.26%   -0.01%     
==========================================
  Files          89       89              
  Lines        5488     5487       -1     
==========================================
- Hits         4844     4843       -1     
  Misses        474      474              
  Partials      170      170              
Impacted Files Coverage Δ
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)
pkg/storage/elasticsearch_dependencies.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc2ecd...417f25f. Read the comment docs.

Signed-off-by: Albert Teoh <albert.teoh@gmail.com>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling
Copy link
Contributor

Thank you, @albertteoh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants