Refined Jaeger instance injection logic #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnotation = true Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1146 +/- ##
==========================================
+ Coverage 88.22% 88.25% +0.02%
==========================================
Files 86 86
Lines 5352 5362 +10
==========================================
+ Hits 4722 4732 +10
Misses 466 466
Partials 164 164
Continue to review full report at Codecov.
|
|
@jpkrohling please review. |
jpkrohling
changed the title
|
This PR isn't fixing the problem. You can reproduce it like this: $ crc start
...
Started the OpenShift cluster
$ make run
INFO[0000] Running the operator locally; watching namespace ""
INFO[0000] Versions arch=amd64 identity=default.jaeger-operator jaeger=1.18.1 jaeger-operator=v1.18.1-18-gf1f57f66 operator-sdk=v0.18.2 os=linux version=go1.14.6
I0729 10:23:30.164784 26167 request.go:621] Throttling request took 1.04514758s, request: GET:https://api.crc.testing:6443/apis/coordination.k8s.io/v1?timeout=32s
INFO[0002] Auto-detected the platform platform=openshift
INFO[0002] Auto-detected ingress api ingress-api=networking
INFO[0002] Automatically adjusted the 'es-provision' flag es-provision=no
INFO[0002] Automatically adjusted the 'kafka-provision' flag kafka-provision=no
INFO[0002] The service account running this operator has the role 'system:auth-delegator', enabling OAuth Proxy's 'delegate-urls' option
INFO[0008] OAuthProxy ImageStream namespace and/or name not defined name= namespace=Then, in another terminal: $ kubectl apply -f deploy/examples/business-application-injected-sidecar.yaml
deployment.apps/myapp createdIn the first terminal, you'll see this: INFO[0010] No suitable Jaeger instances found to inject a sidecar deployment=myapp
INFO[0010] No suitable Jaeger instances found to inject a sidecar deployment=myapp
INFO[0013] No suitable Jaeger instances found to inject a sidecar deployment=myapp |
|
By the way, the steps above can also be reproduced with a regular |
|
My bad: as you pointed out, I forgot one crucial step: the actual Jaeger instance :-) This PR does fix the reported issue. |
jpkrohling
approved these changes
Jul 29, 2020
|
☕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com
Fixes #1116