Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and mount service CA via ConfigMap #1124

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Create and mount service CA via ConfigMap #1124

merged 2 commits into from
Jul 9, 2020

Conversation

jpkrohling
Copy link
Contributor

Fixes #1123

@jpkrohling
Create and mount service CA via ConfigMap
f794f5a 
Fixes jaegertracing#1123

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Jul 8, 2020 •
edited
Loading

Codecov Report

Merging #1124 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   88.09%   88.22%   +0.12%     
==========================================
  Files          86       86              
  Lines        5294     5350      +56     
==========================================
+ Hits         4664     4720      +56     
  Misses        466      466              
  Partials      164      164
Impacted Files Coverage Δ
pkg/config/ca/ca.go 100.00% <100.00%> (ø)
pkg/deployment/agent.go 96.18% <100.00%> (-0.03%) ⬇️
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)
pkg/deployment/collector.go 96.71% <100.00%> (-0.09%) ⬇️
pkg/deployment/ingester.go 96.15% <100.00%> (-0.12%) ⬇️
pkg/deployment/query.go 100.00% <100.00%> (ø)
pkg/inject/sidecar.go 94.47% <100.00%> (+0.08%) ⬆️
pkg/strategy/all_in_one.go 91.48% <100.00%> (+0.37%) ⬆️
pkg/strategy/production.go 97.29% <100.00%> (+0.07%) ⬆️
pkg/strategy/streaming.go 97.05% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dce126...79e82b2. Read the comment docs.

objectiser
objectiser approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few minor comment fixes

pkg/config/ca/ca.go Outdated Show resolved Hide resolved
pkg/config/ca/ca.go Outdated Show resolved Hide resolved
@jpkrohling
Fixed comments in the service CA code
79e82b2 
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@objectiser objectiser added Do Not Merge The PR should not be merged yet. and removed Do Not Merge The PR should not be merged yet. labels Jul 8, 2020
@objectiser objectiser merged commit 11a063f into jaegertracing:master Jul 9, 2020
jpkrohling added a commit to jpkrohling/jaeger-operator that referenced this pull request Dec 15, 2020
@jpkrohling @objectiser
Create and mount service CA via ConfigMap (jaegertracing#1124)
07ad0ee 
* Create and mount service CA via ConfigMap
Fixes jaegertracing#1123

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Fixed comments in the service CA code

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@objectiser objectiser objectiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and mount CA bundle via ConfigMap
2 participants
@jpkrohling @objectiser