Adjusted gRPC options for OpenShift when TLS is enabled

[jpkrohling]

Fixes #1118 by changing the collector's hostname to connect, and removing the 'service name' flag. With this PR, this is how the logs for the sidecar agent looks like:

$ kubectl logs myapp-6f7cc99b66-ckxx9 -c jaeger-agent -f
2020/07/06 13:24:16 maxprocs: Leaving GOMAXPROCS=2: CPU quota undefined
{"level":"info","ts":1594041857.0278215,"caller":"flags/service.go:116","msg":"Mounting metrics handler on admin server","route":"/metrics"}
{"level":"info","ts":1594041857.02812,"caller":"flags/admin.go:120","msg":"Mounting health check on admin server","route":"/"}
{"level":"info","ts":1594041857.0281951,"caller":"flags/admin.go:126","msg":"Starting admin HTTP server","http-addr":":14271"}
{"level":"info","ts":1594041857.028216,"caller":"flags/admin.go:112","msg":"Admin server started","http.host-port":"[::]:14271","health-status":"unavailable"}
{"level":"warn","ts":1594041857.0282385,"caller":"reporter/flags.go:61","msg":"Using deprecated configuration","option":"jaeger.tags"}
{"level":"info","ts":1594041857.0291817,"caller":"grpc/builder.go:57","msg":"Agent requested secure grpc connection to collector(s)"}
{"level":"info","ts":1594041857.0305443,"caller":"grpc@v1.27.1/clientconn.go:106","msg":"parsed scheme: \"dns\"","system":"grpc","grpc_log":true}
{"level":"info","ts":1594041857.042985,"caller":"command-line-arguments/main.go:78","msg":"Starting agent"}
{"level":"info","ts":1594041857.043091,"caller":"healthcheck/handler.go:128","msg":"Health Check state change","status":"ready"}
{"level":"info","ts":1594041857.043513,"caller":"app/agent.go:69","msg":"Starting jaeger-agent HTTP server","http-port":5778}
{"level":"info","ts":1594041857.0844226,"caller":"dns/dns_resolver.go:212","msg":"ccResolverWrapper: sending update to cc: {[{10.129.2.32:14250  <nil> 0 <nil>}] <nil> <nil>}","system":"grpc","grpc_log":true}
{"level":"info","ts":1594041857.0845058,"caller":"grpc@v1.27.1/clientconn.go:948","msg":"ClientConn switching balancer to \"round_robin\"","system":"grpc","grpc_log":true}
{"level":"warn","ts":1594041857.084815,"caller":"grpc@v1.27.1/clientconn.go:1223","msg":"grpc: addrConn.createTransport failed to connect to {10.129.2.32:14250  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 10.129.2.32:14250: connect: connection refused\". Reconnecting...","system":"grpc","grpc_log":true}
{"level":"info","ts":1594041858.0855982,"caller":"base/balancer.go:196","msg":"roundrobinPicker: newPicker called with info: {map[]}","system":"grpc","grpc_log":true}
{"level":"warn","ts":1594041858.087407,"caller":"grpc@v1.27.1/clientconn.go:1223","msg":"grpc: addrConn.createTransport failed to connect to {10.129.2.32:14250  <nil> 0 <nil>}. Err :connection error: desc = \"transport: Error while dialing dial tcp 10.129.2.32:14250: connect: connection refused\". Reconnecting...","system":"grpc","grpc_log":true}
{"level":"info","ts":1594041859.9060602,"caller":"base/balancer.go:196","msg":"roundrobinPicker: newPicker called with info: {map[]}","system":"grpc","grpc_log":true}
{"level":"info","ts":1594041859.9167461,"caller":"base/balancer.go:196","msg":"roundrobinPicker: newPicker called with info: {map[0xc00003e290:{{10.129.2.32:14250  <nil> 0 <nil>}}]}","system":"grpc","grpc_log":true}
{"level":"info","ts":1594041887.0981283,"caller":"dns/dns_resolver.go:212","msg":"ccResolverWrapper: sending update to cc: {[{10.129.2.32:14250  <nil> 0 <nil>}] <nil> <nil>}","system":"grpc","grpc_log":true}

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

[codecov]

Codecov Report

Merging #1119 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
+ Coverage   88.02%   88.05%   +0.02%     
==========================================
  Files          86       86              
  Lines        5263     5273      +10     
==========================================
+ Hits         4633     4643      +10     
  Misses        466      466              
  Partials      164      164              

Impacted Files	Coverage Δ
pkg/inject/sidecar.go	94.35% <100.00%> (-0.03%)	⬇️
pkg/storage/cassandra_dependencies.go	100.00% <0.00%> (ø)
pkg/apis/jaegertracing/v1/jaeger_types.go	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16e1df...39dcf86. Read the comment docs.

[objectiser]

LGTM - although should there be some upgrade logic to modify/remove the flags?

[jpkrohling]

IIRC, we do update the sidecars if they have an outdated configuration (cc @rubenvp8510). We would need some configuration if people are adding the sidecar manually, but in those cases, I don't think the operator should touch the deployment in any case.

[objectiser]

@jpkrohling good point.

[jpkrohling]

I ran @kevinearls tests for OpenShift and they did pass. Merging.