-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraceTTL to cassandra schema spec #1111
Add TraceTTL to cassandra schema spec #1111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
+ Coverage 88.00% 88.05% +0.04%
==========================================
Files 86 86
Lines 5254 5274 +20
==========================================
+ Hits 4624 4644 +20
Misses 466 466
Partials 164 164
Continue to review full report at Codecov.
|
a89b85e
to
73ccd7c
Compare
The |
LGTM. @kevinearls, is this ES failure known to you? If so, we can merge this as is, or we can try to restart the job via GitHub (which typically will cause everything to randomly fail...). Or, @moolen could try to amend and force-push and see if the test passes :-/ |
73ccd7c
to
9d43795
Compare
@jpkrohling which es failure? |
9d43795
to
cf09a6e
Compare
I take that back, i don't think it's flaky: I reproduced the issue locally (i missed exporting the |
If you nee any help, let us know! |
@@ -431,16 +431,33 @@ type JaegerCassandraCreateSchemaSpec struct { | |||
// +optional | |||
Enabled *bool `json:"enabled,omitempty"` | |||
|
|||
// Image specifies the docker container to use to create the cassandra schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not docker container
but container image
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a blocker, though. Would you prefer me to merge this as is, or would you want to get this change in ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, what a misunderstanding :D I'll fix that for sure!
fixes jaegertracing#1101 Signed-off-by: Moritz Johner <beller.moritz@googlemail.com>
cf09a6e
to
429ad55
Compare
Thank you for your contribution! |
This adds the
CassandraSchemaSpec.traceTTL
field to allow the user to specify the TTL for their traces.The TRACE_TTL env var is picked up by this script which creates the schema: https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/cassandra/schema/create.sh
fixes #1101