Added missing displayName to CSV 1.18.1 #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 86 86
Lines 5254 5254
=======================================
Hits 4624 4624
Misses 466 466
Partials 164 164 Continue to review full report at Codecov.
|
|
Shall we add some hack to the generate scrip to add this if missing? |
|
Yes, but not as part of this PR. Before adding a hack, I need to check the docs and see if there's any way to add this field to some annotation. |
objectiser
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids #1085 when opening a PR for the Operator Hub.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de