Refactor common spec elements into a single struct with common proces… #105
Conversation
…sing (merging) Signed-off-by: Gary Brown <gary@brownuk.com>
|
This change is |
Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 99.42% 99.43% +<.01%
==========================================
Files 21 21
Lines 869 879 +10
==========================================
+ Hits 864 874 +10
Misses 5 5
Continue to review full report at Codecov.
|
Signed-off-by: Gary Brown <gary@brownuk.com>
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @objectiser)
a discussion (no related file):
I'm not a big fan of the name JaegerCommonSpec, but I can't think of a better one :-)
pkg/util/util.go, line 54 at r2 (raw file):
} } for _, volumeMount := range commonSpec.VolumeMounts {
nit: I think you can do something like:
volumeMounts = append(volumeMounts, commonSpec.VolumeMounts...)Signed-off-by: Gary Brown <gary@brownuk.com>
There was a problem hiding this comment.
Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @jpkrohling and @objectiser)
pkg/util/util.go, line 54 at r2 (raw file):
Previously, jpkrohling (Juraci Paixão Kröhling) wrote…
nit: I think you can do something like:
volumeMounts = append(volumeMounts, commonSpec.VolumeMounts...)
Good point - changed.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @objectiser)
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
…sing (merging)
Decided it was better to factor out the common spec elements at the top level and in the components, as there will be others coming soon (e.g. resources).
Signed-off-by: Gary Brown gary@brownuk.com