Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source of oauth-proxy image from the imagestream #1049

Merged
merged 1 commit into from
May 4, 2020
Merged

Change source of oauth-proxy image from the imagestream #1049

merged 1 commit into from
May 4, 2020

Conversation

objectiser
Copy link
Contributor

No description provided.

Signed-off-by: Gary Brown <gary@brownuk.com>
@objectiser
Copy link
Contributor Author

@kevinearls Could you review this please?

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1049 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   64.58%   64.58%           
=======================================
  Files          84       84           
  Lines        6715     6715           
=======================================
  Hits         4337     4337           
  Misses       2236     2236           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dc7d3...a099694. Read the comment docs.

Copy link
Contributor

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@objectiser objectiser merged commit 62e2702 into jaegertracing:master May 4, 2020
@objectiser objectiser deleted the imagestream2 branch May 4, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants