Allow oauth proxy imagestream to be used by specifying the namespace/… #1035
Conversation
…name Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
=======================================
Coverage 64.23% 64.23%
=======================================
Files 83 83
Lines 6627 6627
=======================================
Hits 4257 4257
Misses 2229 2229
Partials 141 141 Continue to review full report at Codecov.
|
Signed-off-by: Gary Brown <gary@brownuk.com>
objectiser
changed the title
|
Small comment, this looks good. I tested in my local environment, with and without specify an image stream and it works correctly, I was able to create all-in-one and production strategies, no seeing errors on logs. |
| return | ||
| } | ||
|
|
||
| image := fmt.Sprintf("%s:%s", imageStream.Status.DockerImageRepository, imageStream.Status.Tags[0].Tag) |
There was a problem hiding this comment.
Is it OK to assume that we will always use the first tag? I would say that the answer is yes, at least for now, but not sure.
There was a problem hiding this comment.
Yes, the comment on the type indicates that the first tag is the current one.
Tags are a historical record of images associated with each tag. The first entry in the TagEvent array is the currently tagged image
|
@rubenvp8510 Thanks for testing this! |
jaegertracing#1035) * Allow oauth proxy imagestream to be used by specifying the namespace/name Signed-off-by: Gary Brown <gary@brownuk.com> * Add ImageStream type only to the Scheme Signed-off-by: Gary Brown <gary@brownuk.com>
…name