Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure 'make generate' has been executed when model changes are made #101

Merged

Conversation

jpkrohling
Copy link
Contributor

Closes #99

When a model has been changed but the deep copy functions haven't been changed, this is shown:

$ make ci
Run code-generation for custom resources
Generating deepcopy funcs

Build failed: a model has been changed but the deep copy functions aren't up to date. Run 'make generate' and update your PR.
make: *** [Makefile:27: ensure-generate-is-noop] Error 1

Otherwise, this is what a successful build looks like now:

$ make ci
Run code-generation for custom resources
Generating deepcopy funcs

Checking...
Formatting code...
Linting...
Building...
Running unit tests...
?   	github.com/jaegertracing/jaeger-operator/cmd	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/apis/io/v1alpha1	0.063s	coverage: 15.5% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/start	[no test files]
?   	github.com/jaegertracing/jaeger-operator/pkg/cmd/version	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/controller	0.010s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/deployment	0.025s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/ingress	0.054s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/inject	0.013s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/route	0.019s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/service	0.008s	coverage: 100.0% of statements
ok  	github.com/jaegertracing/jaeger-operator/pkg/storage	0.025s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/stub	[no test files]
ok  	github.com/jaegertracing/jaeger-operator/pkg/util	0.004s	coverage: 100.0% of statements
?   	github.com/jaegertracing/jaeger-operator/pkg/version	[no test files]

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling self-assigned this Nov 8, 2018
@jpkrohling
Copy link
Contributor Author

This change is Reviewable

@objectiser
Copy link
Contributor

@jpkrohling Looks like the operator SDK will need to be installed before running the generate.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #101 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          21       21           
  Lines         869      869           
=======================================
  Hits          864      864           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1479f7c...dda859a. Read the comment docs.

@jpkrohling
Copy link
Contributor Author

@objectiser CI is now passing, I think it's OK to merge, right?

@objectiser objectiser merged commit 12edd3a into jaegertracing:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants