Fix autodetect restarting platform from OpenShift to Kubernetes #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
- Coverage 64.56% 64.55% -0.02%
==========================================
Files 82 82
Lines 6542 6540 -2
==========================================
- Hits 4224 4222 -2
Misses 2177 2177
Partials 141 141
Continue to review full report at Codecov.
|
Signed-off-by: Gary Brown <gary@brownuk.com>
|
@rubenvp8510 Would you be able to review? It is related to https://issues.redhat.com/browse/TRACING-1117 |
|
cc @jpkrohling for future reference :) |
Signed-off-by: Gary Brown <gary@brownuk.com>
kevinearls
approved these changes
Apr 5, 2020
|
This looks good. |
|
@kevinearls @rubenvp8510 Thanks - will merge then. |
jpkrohling
pushed a commit
to jpkrohling/jaeger-operator
that referenced
this pull request
Dec 15, 2020
…ertracing#1003) * Fix autodetect restarting platform from OpenShift to Kubernetes Signed-off-by: Gary Brown <gary@brownuk.com> * Add extra check Signed-off-by: Gary Brown <gary@brownuk.com> * Further change to trigger tests Signed-off-by: Gary Brown <gary@brownuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Brown gary@brownuk.com