Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

The static method initTracer in configuration.js missing support for contextKey #254

Closed

Description

It looks like support for an alternative to the default TRACER_STATE_HEADER_NAME defined in constant.js has been added to tracer.js and text_map_code.js by allowing a 'contextKey' to be passed as an option. However, the initTracer method in configuration.js does not include support for this when creating a new Tracer object. The current code reads like this:

return new Tracer(config.serviceName, reporter, sampler, { metrics: options.metrics, logger: options.logger, tags: options.tags, });

Fixing this seems like a simple update - something like this:

return new Tracer(config.serviceName, reporter, sampler, { metrics: options.metrics, logger: options.logger, tags: options.tags, contextKey: options.contextKey });

Is there a reason that contextKey is not supported in the initTracer method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions