This repository was archived by the owner on Apr 28, 2022. It is now read-only.
Enrich the ways one can configure Jaeger with ASP.Net's IConfiguration #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's very useful to use other configuration providers and IConfiguration offers this possibility. see https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-2.1 Signed-off-by: Mihai Popescu <mihai@unity3d.com>
mihaipopescu
force-pushed
the
use-iconfiguration
branch
from
142caf1 to
ba8d371
Compare
|
If the direction is accepted, I think some documentation changes will be nice to add as well. |
|
ASP.NET Core uses It can be used in .NET Framework Console applications or ASP.NET WebForms applications. |
Falco20019
approved these changes
Nov 13, 2018
Signed-off-by: Mihai Popescu <mihai@unity3d.com>
|
I prefer this solution over the compromise I proposed in #108. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
see https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-2.1