Skip to content

Ensure all links have trailing slashes (v1 docs) #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Jun 2, 2025

Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 3a8ea87
🔍 Latest deploy log https://app.netlify.com/projects/romantic-neumann-1959d7/deploys/683d09e28a96d0000810f8e5
😎 Deploy Preview https://deploy-preview-907--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-im-v1-link-cleanup-2025-06-01 branch from edcd980 to 3a8ea87 Compare June 2, 2025 02:18
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection but what's wrong with links not having trailing slash? they still work.

@yurishkuro yurishkuro merged commit 2f3b661 into jaegertracing:main Jun 2, 2025
12 checks passed
@chalin chalin deleted the chalin-im-v1-link-cleanup-2025-06-01 branch June 2, 2025 02:40
@chalin
Copy link
Collaborator Author

chalin commented Jun 2, 2025

no objection but what's wrong with links not having trailing slash? they still work.

It follows the general guidance of using canonical paths in our docs when htmltest is the link checker. That is, a path (or more generally URL), is canonical if the HTTP status of requesting it is 200, not 30X.

Admittedly, for the older docs, it might not have been necessary, but it was relatively easy to fix using regexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants