Skip to content

Drop obsolete GA UA ID from Hugo config #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented May 28, 2025

Signed-off-by: Patrice Chalin <chalin@users.noreply.github.com>
Copy link

netlify bot commented May 28, 2025

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 7f547ee
🔍 Latest deploy log https://app.netlify.com/projects/romantic-neumann-1959d7/deploys/6837a268955ca20008494f0b
😎 Deploy Preview https://deploy-preview-887--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chalin chalin mentioned this pull request May 28, 2025
2 tasks
@@ -6,7 +6,6 @@ pygmentsUseClasses: true
disableKinds: ["taxonomy"]
canonifyURLs: true
theme: ["basetheme", "jaeger-docs"]
googleAnalytics: "UA-148208642-1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we upgrade it instead of dropping? iiuc the Hugo configuration is still the same and accept different versions of GA ID.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've configured it via Netlify. For details, see #886.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new GA4 ID is properly functioning now. This PR is just a cleanup step.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@yurishkuro
Copy link
Member

where in Netlify is it configured? I would like to document it.

@yurishkuro yurishkuro merged commit 941b99a into jaegertracing:main May 29, 2025
12 checks passed
@chalin chalin deleted the patch-1 branch May 29, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants