Skip to content

Commit

Permalink
[NPM][Inliner] Temporarily remove inline_stats test case for always
Browse files Browse the repository at this point in the history
inline

The stats are printed at InlinePass destruction. When we have 2 of them,
it appears the destruction order of the Passes std::vector of the pass
manager differs in msan builds - example:
http://lab.llvm.org:8011/#/builders/74/builds/2135.

This reproes locally, too.

Temporarily removing the sub-test case, to green the build, and will
follow up with a stat dumping alternative that does not depend on vector
element dtor order.
  • Loading branch information
mtrofin committed Jan 16, 2021
1 parent be68c92 commit a61e42e
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions llvm/test/Transforms/Inline/inline_stats.ll
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
; RUN: opt -S -passes=inliner-wrapper-no-mandatory-first -inliner-function-import-stats=basic < %s 2>&1 | FileCheck %s --check-prefixes=CHECK-BASIC,CHECK
; RUN: opt -S -passes=inliner-wrapper-no-mandatory-first -inliner-function-import-stats=verbose < %s 2>&1 | FileCheck %s --check-prefixes="CHECK-VERBOSE",CHECK

; RUN: opt -S -passes=inliner-wrapper -inliner-function-import-stats=basic < %s 2>&1 | FileCheck %s --check-prefix=MANDATORY-FIRST
; RUN: opt -S -passes=inliner-wrapper -inliner-function-import-stats=verbose < %s 2>&1 | FileCheck %s --check-prefix=MANDATORY-FIRST

; CHECK: ------- Dumping inliner stats for [<stdin>] -------
; CHECK-BASIC-NOT: -- List of inlined functions:
; CHECK-BASIC-NOT: -- Inlined not imported function
Expand All @@ -30,21 +27,6 @@
; CHECK: non-imported functions inlined anywhere: 1 [33.33% of non-imported functions]
; CHECK: non-imported functions inlined into importing module: 1 [33.33% of non-imported functions]

; MANDATORY-FIRST: -- Summary:
; MANDATORY-FIRST: All functions: 10, imported functions: 7
; MANDATORY-FIRST: inlined functions: 4 [40% of all functions]
; MANDATORY-FIRST: imported functions inlined anywhere: 3 [42.86% of imported functions]
; MANDATORY-FIRST: imported functions inlined into importing module: 2 [28.57% of imported functions], remaining: 5 [71.43% of imported functions]
; MANDATORY-FIRST: non-imported functions inlined anywhere: 1 [33.33% of non-imported functions]
; MANDATORY-FIRST: non-imported functions inlined into importing module: 1 [33.33% of non-imported functions]
; MANDATORY-FIRST: -- Summary:
; MANDATORY-FIRST: All functions: 10, imported functions: 7
; MANDATORY-FIRST: inlined functions: 1 [10% of all functions]
; MANDATORY-FIRST: imported functions inlined anywhere: 1 [14.29% of imported functions]
; MANDATORY-FIRST: imported functions inlined into importing module: 1 [14.29% of imported functions], remaining: 6 [85.71% of imported functions]
; MANDATORY-FIRST: non-imported functions inlined anywhere: 0 [0% of non-imported functions]
; MANDATORY-FIRST: non-imported functions inlined into importing module: 0 [0% of non-imported functions]

define void @internal() {
call fastcc void @external1()
call fastcc void @internal2()
Expand Down

0 comments on commit a61e42e

Please sign in to comment.