Revert "[Analyzer][WebKit] RefCntblBaseVirtualDtorChecker"

This reverts commit f7c7e8a. Breaks build everywhere.
jaebaek · May 21, 2020 · 1108f5c · 1108f5c
1 parent f8b4412
commit 1108f5c
Show file tree

Hide file tree

Showing 11 changed files with 0 additions and 669 deletions.
diff --git a/clang/docs/analyzer/checkers.rst b/clang/docs/analyzer/checkers.rst
@@ -1374,33 +1374,6 @@ double freed, or use after freed. This check attempts to find such problems.
    zx_handle_close(sb);
  }
 
-WebKit
-^^^^^^
-
-WebKit is an open-source web browser engine available for macOS, iOS and Linux.
-This section describes checkers that can find issues in WebKit codebase.
-
-Most of the checkers focus on memory management for which WebKit uses custom implementation of reference counted smartpointers.
-Checker are formulated in terms related to ref-counting:
-* *Ref-counted type* is either ``Ref<T>`` or ``RefPtr<T>``.
-* *Ref-countable type* is any type that implements ``ref()`` and ``deref()`` methods as ``RefPtr<>`` is a template (i. e. relies on duck typing).
-* *Uncounted type* is ref-countable but not ref-counted type.
-
-.. _webkit-WebKitRefCntblBaseVirtualDtor:
-
-webkit.WebKitRefCntblBaseVirtualDtor
-""""""""""""""""""""""""""""""""""""
-All uncounted types used as base classes must have a virtual destructor.
-
-Ref-counted types hold their ref-countable data by a raw pointer and allow implicit upcasting from ref-counted pointer to derived type to ref-counted pointer to base type. This might lead to an object of (dynamic) derived type being deleted via pointer to the base class type which C++ standard defines as UB in case the base class doesn't have virtual destructor ``[expr.delete]``.
-
-.. code-block:: cpp
- struct RefCntblBase {
-   void ref() {}
-   void deref() {}
- };
-
- struct Derived : RefCntblBase { }; // warn
 
 .. _alpha-checkers:
 

diff --git a/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td b/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
@@ -116,9 +116,6 @@ def NonDeterminismAlpha : Package<"nondeterminism">, ParentPackage<Alpha>;
 def Fuchsia : Package<"fuchsia">;
 def FuchsiaAlpha : Package<"fuchsia">, ParentPackage<Alpha>;
 
-def WebKit : Package<"webkit">;
-def WebKitAlpha : Package<"webkit">, ParentPackage<Alpha>;
-
 //===----------------------------------------------------------------------===//
 // Core Checkers.
 //===----------------------------------------------------------------------===//
@@ -1623,13 +1620,3 @@ def FuchsiaLockChecker : Checker<"Lock">,
 
 } // end fuchsia
 
-//===----------------------------------------------------------------------===//
-// WebKit checkers.
-//===----------------------------------------------------------------------===//
-
-let ParentPackage = WebKit in {
-
-def WebKitRefCntblBaseVirtualDtorChecker : Checker<"WebKitRefCntblBaseVirtualDtor">,
-  HelpText<"Check for any ref-countable base class having virtual destructor.">,
-  Documentation<HasDocumentation>;
-} // end webkit
diff --git a/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt b/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
@@ -121,8 +121,6 @@ add_clang_library(clangStaticAnalyzerCheckers
   VLASizeChecker.cpp
   ValistChecker.cpp
   VirtualCallChecker.cpp
-  WebKit/PtrTypesSemantics.cpp
-  WebKit/RefCntblBaseVirtualDtorChecker.cpp
 
   LINK_LIBS
   clangAST

diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h b/clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUtils.h
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/DiagOutputUtils.h b/clang/lib/StaticAnalyzer/Checkers/WebKit/DiagOutputUtils.h
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.h b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.h