Distinguish image-not-found from authentication errors#216
Merged
Conversation
When the registry returns HTTP 404 for a manifest request, return a typed ErrImageNotFound instead of a generic message. The HTTP handlers now detect this error via errors.As and respond with HTTP 404 and a clear "image not found: <image>" message rather than HTTP 500 with a misleading "authentication failed" message. For the case where the auth server itself rejects the token request, the fetchToken error message now explicitly notes that the image may not exist or may be private, not just that credentials are wrong. https://claude.ai/code/session_01CCxZ3U3tT8jE5XFybD6Aup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the registry returns HTTP 404 for a manifest request, return a![]()
" message rather than HTTP 500 with a
typed ErrImageNotFound instead of a generic message. The HTTP handlers
now detect this error via errors.As and respond with HTTP 404 and a
clear "image not found:
misleading "authentication failed" message.
For the case where the auth server itself rejects the token request,
the fetchToken error message now explicitly notes that the image may
not exist or may be private, not just that credentials are wrong.
https://claude.ai/code/session_01CCxZ3U3tT8jE5XFybD6Aup