Conversation
jadolg
force-pushed
the
add-cache-cleaning
branch
from
46eb417 to
670e44e
Compare
The cache cleanup logic was using the file's modification time (mtime) to determine when to evict a file. This is incorrect for a cache where files are written once and read multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With heavy adoption and people downloading big images my poor server is running out of space in less than a week. I have a cronjob cleaning all Sundays but that's not enough, so now we will have "per-file" cache. Every hour we will remove all files older than the maximum cache age (default: 48h)