Skip to content

Extract file copying logic into a new copyFileToTar helper function #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jadolg merged 1 commit into from
Jan 6, 2026
Merged

Extract file copying logic into a new copyFileToTar helper function #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions files.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,18 @@ func createTar(srcDir, destPath string) error {
return nil
}

f, err := os.Open(path)
if err != nil {
return err
}
defer closeWithLog(f, "file")
return copyFileToTar(tw, path)
})
}

_, err = io.Copy(tw, f)
// copyFileToTar copies a single file to a tar writer, ensuring the file is closed immediately after copying
func copyFileToTar(tw *tar.Writer, path string) error {
f, err := os.Open(path)
if err != nil {
return err
})
}
defer closeWithLog(f, "file")

_, err = io.Copy(tw, f)
return err
}