Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update angular folder structure/naming & fix generators accordingly #142

Closed
7 tasks done
jadjoubran opened this issue Jan 18, 2016 · 6 comments
Closed
7 tasks done

Comments

@jadjoubran
Copy link
Owner

  • angular/app should be renamed to angular/app/pages/
  • angular/directives should be renamed to angular/app/components
  • .directive.js should become .component.js
  • page_name.page.html (for page views)
  • finalize other breaking changes
  • update documentation
  • upgrade guide

Most of these tasks help in angular 2 migration

@jadjoubran
Copy link
Owner Author

ping @jsalhani
Let me know if there's anything else that needs to be fixed

@jadsalhani
Copy link
Collaborator

Maybe have them all under app?

app/
     components/
     pages/

Something like this would make a bit more sense imo since they all make the app
And also the html in the pages could have something like .page.html or .container.html to differentiate

@jadjoubran
Copy link
Owner Author

awesome, thanks!
updated the description

@jadjoubran
Copy link
Owner Author

Thanks @jsalhani for reviewing this!

Will be available as of version 3.1 with #121 (contains breaking changes)

@ChadTaljaardt
Copy link

Thanks for the updates 👍

@jadjoubran
Copy link
Owner Author

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants