Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ability to pass $scope in DialogService #141

Closed
jadjoubran opened this issue Jan 18, 2016 · 3 comments
Closed

Remove ability to pass $scope in DialogService #141

jadjoubran opened this issue Jan 18, 2016 · 3 comments
Labels
Easy Pick enhancement PR Welcome Priority: High

Comments

@jadjoubran
Copy link
Owner

Since all controllers & directives are now using ControllerAs syntax.
Communication inside dialogs should use services
@shiruken1
Copy link
Contributor

I like the idea, so long as it's well documented, so that a newbie to
Angular doesn't ask why it's not working, or become frustrated
unnecessarily.
On Jan 18, 2016 2:12 AM, "Jad Joubran" notifications@github.com wrote:

Since all controllers & directives are now using ControllerAs syntax.
Communication inside dialogs should use services

—
Reply to this email directly or view it on GitHub
#141
.

@jadjoubran
Copy link
Owner Author

👍

@jadjoubran
Copy link
Owner Author

Updated!
Second argument is now the additional options that are passed to $mdDialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Pick enhancement PR Welcome Priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jadjoubran @shiruken1