remove controllers to promote components. closes #154

jadjoubran · Jan 24, 2016 · ee51d24 · ee51d24
1 parent 6cefca4
commit ee51d24
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 29 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 - reverted to `gulp-minify-css` [#144](https://github.com/jadjoubran/laravel5-angular-material-starter/issues/144)
 - EcmaScript 6 generators thanks to [@jsalhani](https://github.com/jsalhani) [#152](https://github.com/jadjoubran/laravel5-angular-material-starter/pull/152)
 - Ignore (stop tracking) public/js and public/css
+- Remove all controllers to promote components (Angular 1.5) [#154](https://github.com/jadjoubran/laravel5-angular-material-starter/issues/154)
 
 ### 3.0.6
 - npm dependencies cleanup [#133](https://github.com/jadjoubran/laravel5-angular-material-starter/issues/133)

diff --git a/angular/app/pages/landing/landing.controller.js b/angular/app/pages/landing/landing.controller.js
diff --git a/angular/app/pages/landing/landing.html b/angular/app/pages/landing/landing.html
@@ -1,4 +1,4 @@
-<div class="Page-Container Landing" ng-controller="LandingController as vm" ng-class="{'iOS-hack': vm.iOS}">
+<div class="Page-Container Landing" class="iOS-hack">
 	<div layout="column" class="Landing-cover" layout-align="center center">
 		<div class="md-headline Landing-subtitle">Build your next powerful web app</div>
 		<h1 class="md-display-3 Landing-heading"><strong>laravel angular</strong> <span class="Landing-headingLight">material starter</span></h1>
@@ -10,7 +10,7 @@ <h1 class="md-display-3 Landing-heading"><strong>laravel angular</strong> <span
 		<div layout="column" layout-gt-sm="row">
 			<div flex="50" class="Landing-laravel" layout-align="center center">
 				<h2 class="md-display-2 Landing-laravelAngular-title">Laravel</h2>
-				<div class="md-title Landing-laravelAngular-subtitle">{{vm.laravel_description}}</div>
+				<div class="md-title Landing-laravelAngular-subtitle">Response macros integrated with your Angular app</div>
 				<br/>
 				<div class="DemoCode">
 					<span class="DemoCode-operator">&lt;?php</span><br/>
@@ -30,12 +30,12 @@ <h2 class="md-display-2 Landing-laravelAngular-title">Laravel</h2>
 			</div>
 			<div flex="50" class="Landing-angular" layout-align="center center">
 				<h2 class="md-display-2 Landing-laravelAngular-title">Angular</h2>
-				<div class="md-title Landing-laravelAngular-subtitle">{{vm.angular_description}}</div>
+				<div class="md-title Landing-laravelAngular-subtitle">Query your API without worrying about validations</div>
 				<br/>
 				<div class="DemoCode">
 					(<span class="DemoCode-secondary">function</span>(){<br/>
 					<span class="DemoCode-string">"use strict"</span>;<br/><br/>
-					<span class="DemoCode-secondary">function</span> <span class="DemoCode-highlight">LandingController</span>(API) {<br/>
+					<span class="DemoCode-secondary">function</span> <span class="DemoCode-highlight">PostsComponent</span>(API) {<br/>
 					<br/>
 					&nbsp;&nbsp;&nbsp;&nbsp;<span class="DemoCode-highlight">this</span>.<span class="DemoCode-highlight">getPosts</span> = <span class="DemoCode-secondary">function</span>(){<br/>
 					&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;API.all(<span class="DemoCode-string">'posts'</span>).get()<br/>

diff --git a/angular/index.controllers.js b/angular/index.controllers.js
diff --git a/angular/index.main.js b/angular/index.main.js
@@ -4,9 +4,6 @@ import './index.modules';
 //Config
 import './index.config';
 
-//Controllers
-import './index.controllers';
-
 //Run
 import './index.routes';
 

diff --git a/angular/index.modules.js b/angular/index.modules.js
@@ -1,5 +1,4 @@
 angular.module('app', [
-	'app.controllers',
 	'app.filters',
 	'app.services',
 	'app.components',
@@ -9,8 +8,10 @@ angular.module('app', [
 ]);
 
 angular.module('app.routes', []);
-angular.module('app.controllers', ['ui.router', 'ngMaterial', 'ngStorage', 'restangular', 'angular-loading-bar']);
 angular.module('app.filters', []);
 angular.module('app.services', []);
-angular.module('app.components', []);
 angular.module('app.config', []);
+angular.module('app.components', [
+	'ui.router', 'ngMaterial', 'ngStorage',
+	'restangular', 'angular-loading-bar'
+]);