build tools

[bruceravel]

Gentlemen,

In the project for which I am using json-fortran, I have chosen to use SCons as the build system.

I find that the build.sh file works just fine, but it's a little too simple for purposes. I have no problem with CMake, but as written the CMake files for json-fortran have a requirement on jsonlint (there are many things called jsonlint, you seem to be using this one, right?), which, in turn, requires that node.js be installed. node.js is supercool, but not something I want to impose upon my users.

Here (https://gist.github.com/bruceravel/c74dd55c5a33a6966437) is the SConstruct file that I came up with. It very closely emulates the behavior of the build.sh script, but with logic for dependencies, cleaning, and installing.

If you think that others might appreciate this, then you can drop it in the top directory under the name SConstruct. With it in place (and with SCons installed), the library is built by typing scons and installed by scons install or sudo scons install. I can also imply leave the gist in place for linking to.

If you would rather not have a proliferation of build tools in the repo, I completely understand.

Regardless, I am grateful for json-fortran. It has really filled a need in my work. 😃

[jacobwilliams]

That's great! I don't mind adding it at all. I'll take a look at what you've done (I've used SCons in the past but not for a while). Do you want to submit a pull request, or just have me grab it from your link? Are you willing to release this file under the same BSD-style license as the main json-fortran LICENSE?

[bruceravel]

Either way is fine by me. If you'd prefer a PR, let me know and I'll do one, otherwise just grab the gist.

Your license is fine.

Cheers,
B

[jacobwilliams]

Done and done. Thanks again!

[zbeekman]

@bruceravel

[zbeekman]

Dang it, editing on my phone on vacation... I'll look into the CMake dependency on jsonlint... It should be very simple to fail more gracefully or turn this into an option which is off by default. It is only there for testing and QA reasons, and it was an oversight of me to set the build system up to cause challenges for those not interested in testing the code after building it, etc.

[zbeekman]

@jacobwilliams I think this should stay open until I fix the CMake system so that it doesn’t fail if no jsonlint is present… Also I need to give the testing some TLC after all your recent changes.

[jacobwilliams]

That's fine.

[kmanalo]

I was about to form a new issue, but I see the issue is already pointed out here, just notes on what I'm seeing on my end (when no jsonlint installed). Great tool btw!

CMake Error at CMakeLists.txt:204 (set_tests_properties):
  set_tests_properties Can not find test to add properties to: validate-test2


CMake Error at CMakeLists.txt:209 (set_tests_properties):
  set_tests_properties Can not find test to add properties to: validate-test4


CMake Error at CMakeLists.txt:237 (set_tests_properties):
  set_tests_properties Can not find test to add properties to:
  validate-test2-static


CMake Error at CMakeLists.txt:242 (set_tests_properties):
  set_tests_properties Can not find test to add properties to:
  validate-test4-static


CMake Warning at CMakeLists.txt:256 (message):
  For full test coverage please download and install jsonlint, a NODEJS
  package <http://nodejs.org>

[zbeekman]

Currently there are 2 major issues with the CMake build system using HEAD:

1. An issue with dynamically computing the ROBODoc output files
2. The handling of testing in the case that jsonlint is missing is only partially accounted for and a number of tests assume it to be present even when it's not.

I don't think it will be hard to fix but I'm visiting family at the moment and may not be able to get to it until next week.