Skip to content

Commit

Permalink
Clarify version number for which the example works
Browse files Browse the repository at this point in the history
adnanh#461 changed option name and in adnanh#528 (comment), @moorereason suggests to look at old tags of example documentation. This would mean that users have to read through random old documentation to discover why their packaged version doesn't work . Suggesting that clarity in the examples is preferable.

Recall that renaming this doesn't give the user some easy exception. It just mean that the trigger isn't satisfied, so there are A LOT of options for debugging.

(which takes a lot of time to do, so that's why this information is important)
  • Loading branch information
benjaoming authored Apr 25, 2021
1 parent e329b6d commit 1ec494f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions docs/Hook-Examples.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ although the examples on this page all use the JSON format.
* [Pass string arguments to command](#pass-string-arguments-to-command)

## Incoming Github webhook

This example works on 2.8+ versions of Webhook - if you are on a previous series, change `payload-hmac-sha1` to `payload-hash-sha1`.

```json
[
{
Expand Down

0 comments on commit 1ec494f

Please sign in to comment.